Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location info for timezones #263

Closed
wants to merge 1 commit into from

Conversation

arul-gupta
Copy link

This commit fixes #255.

I've made changes to parse the location info from the tz data files and store it in the current zone info files while taking care that none of the existing functionality breaks.
While there is no explicit mapping from country to timezones, the same can be obtained by iterating over the available IDs and then getting the location-info(countries, latitude, longitude) for each of the timezones.

Have included the required 3 data files from IANA in the tz data.

@jodastephen
Copy link
Member

Thanks for the PR.

As you may have guessed, I'm not going to merge this PR. The Joda-Time project has now reached primarily maintenance mode as stated on the homepage "Joda-Time is considered to be a largely “finished” project. No major enhancements are planned."

Adding this PR to the codebase would be a significant increase in the codebase surface area, resulting in me maintaining more code in my spare time. I also know that the lead of the TZDB project is wary of including location data in the data sets that are published, so it is possible that the data set may disappear in future. If this PR had existed ten to twelve years ago, it probably would have been merged. But with Java SE 8 containing a new date and time library that better models the domain, Joda-Time is now on the gentle slope of decline.

Thanks again for the time taken to raise the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add methods to expose country-to-zone mapping and other meta data
2 participants